IMO we should expand on the user-facing effect in the option descriptions - i.e., for WITH_LLVM_STATIC the Clang/LLVM toolchain binaries will be much larger but start more quickly. WITHOUT_LLVM_STATIC the Clang/LLVM binaries will be smaller, but will take longer to start.

fix failure test if more than one fw file is in the fail list

Correct test

Reduce installer memory requirement to 256 MiB (QEMU's default was 128 MiB where the pkg OOM was observed).

This could instead or in addition be a reference to the Persistent Configuration section later in the document -- but either way I think it's good to provide a reference here.

Show recommended minimum too

Add a comment

comment too, as suggested by @kp

still need to check for offline packages on the install media if no MANIFEST

In D50908#1162130, @lwhsu wrote:

In D50908#1162086, @emaste wrote:

Will update the proposed commit message with something like The rendered paper is available at https://papers.freebsd.org/1998/phk-malloc.files/phk-malloc-paper.pdf

It's also available at https://papers.freebsd.org/1998/phk-malloc/

better to call cap_enter() instead of caph_enter()?

Isn't it time to remove all of src/doc/share/papers

The PR has a list -- usr.bin/bmake/unit-tests/Makefile has both MALLOC_CONF and MALLOC_OPTIONS set so it's fine, although inconsistent between the two.

Update sysctl numbers

What is the rationale behind this change?

include bpf tests in same review

Add reference to paper

Fixup -- there is no --default-yes in bsddialog and the options were swapped.

Use include as Kyle suggests

Build failure was:

In file included from /home/emaste/src/freebsd-git/wipbsd/cddl/lib/libtpool/tests/libtpool_test.c:8:
In file included from /usr/obj/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/atf-c.h:30:
In file included from /usr/obj/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/atf-c/macros.h:29:
/home/emaste/src/freebsd-git/wipbsd/sys/contrib/openzfs/lib/libspl/include/string.h:34:15: error: expected parameter declarator
   34 | extern size_t strlcat(char *dst, const char *src, size_t dstsize);
      |               ^                             
/usr/obj/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/ssp/string.h:137:37: note: expanded from macro 'strlcat'
  137 |     __strlcat_chk(dst, src, dstlen, __ssp_bos(dst))
      |                                     ^
/usr/obj/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/ssp/ssp.h:66:51: note: expanded from macro '__ssp_bos'
   66 | #define __ssp_bos(ptr) __builtin_object_size(ptr, __SSP_FORTIFY_LEVEL > 1)
      |                                                   ^
/usr/obj/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/ssp/ssp.h:43:32: note: expanded from macro '__SSP_FORTIFY_LEVEL'
   43 | #   define __SSP_FORTIFY_LEVEL 2
      |                                ^

Correct _ vs . typo

See also tools/pkgbase/metalog_reader.lua - will take a look at migrating to using this module instead later on