Page MenuHomeFreeBSD
Differential D50910

tests: Update for jemalloc's option parsing
ClosedPublic
Actions

Authored by emaste on Tue, Jun 17, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 20, 6:22 AM
Unknown Object (File)
Fri, Jun 20, 5:40 AM
Unknown Object (File)
Fri, Jun 20, 5:38 AM
Unknown Object (File)
Fri, Jun 20, 5:11 AM
Unknown Object (File)
Thu, Jun 19, 3:01 PM
Unknown Object (File)
Wed, Jun 18, 5:29 AM
Unknown Object (File)
Tue, Jun 17, 5:43 PM
Subscribers
imp
olce

Details

Reviewers
jilles
markj
olce
Commits
rG4f33d073003c: tests: Update for jemalloc's option parsing
Summary
MALLOC_OPTIONS=J -> MALLOC_CONF=junk:true

PR:             287357
Event:          Kitchener-Waterloo Hackathon 202506
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Tue, Jun 17, 3:35 PM
Herald added a reviewer: jilles. · View Herald TranscriptTue, Jun 17, 3:35 PM
emaste requested review of this revision.Tue, Jun 17, 3:35 PM
emaste updated this revision to Diff 157191.Tue, Jun 17, 3:40 PM
emaste retitled this revision from sh: Update tests for jemalloc's option parsing to tests: Update for jemalloc's option parsing.

include bpf tests in same review

markj accepted this revision.Tue, Jun 17, 3:51 PM
This revision is now accepted and ready to land.Tue, Jun 17, 3:51 PM
Closed by commit rG4f33d073003c: tests: Update for jemalloc's option parsing (authored by emaste). · Explain WhyTue, Jun 17, 3:53 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG4f33d073003c: tests: Update for jemalloc's option parsing.
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 17, 3:53 PM
olce added a reviewer: olce.Tue, Jun 17, 3:59 PM
olce added a subscriber: olce.

Seems fine.

There's also a couple of occurences of MALLOC_OPTIONS in contrib code (bmake, openssh (they just don't support MALLOC_CONF in their configure.ac)), I guess you want to handle separately (or not right now)?

Seems we could change also usr.bin/bmake/unit-tests/Makefile (not contrib).

emaste added a comment.Tue, Jun 17, 4:07 PM

The PR has a list -- usr.bin/bmake/unit-tests/Makefile has both MALLOC_CONF and MALLOC_OPTIONS set so it's fine, although inconsistent between the two.

olce added a comment.Tue, Jun 17, 4:11 PM
In D50910#1162053, @emaste wrote:

The PR has a list -- usr.bin/bmake/unit-tests/Makefile has both MALLOC_CONF and MALLOC_OPTIONS set so it's fine, although inconsistent between the two.

Hadn't seen the PR.

Revision Contents
Changeset List

PathSize
bin/
sh/
tests/
execution/
4 lines
tools/
regression/
bpf/
bpf_filter/
2 lines

Diff 157197

View Options

bin/sh/tests/execution/func1.0

Loading...
View Options

tools/regression/bpf/bpf_filter/Makefile

Loading...
OSZAR »