src.opts.mk: Default LLVM_ASSERTIONS off
Needs ReviewPublic
Actions

Authored by kbowling on Sat, May 17, 12:14 AM.

Details

Reviewers

dim
emaste
jrtc27

Summary

This noticeably slows down the compiler execution.

It seems like it should be toggled on in the import branches for test and exp-run and default off otherwise.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Sat, May 17, 12:14 AM

Herald added subscribers: ziaee, imp, bdrewery. · View Herald TranscriptSat, May 17, 12:14 AM

kbowling requested review of this revision.Sat, May 17, 12:14 AM

Or, like WITNESS or MALLOC_PRODUCTION, on in HEAD and off in stable branches?

In D50388#1149945, @jrtc27 wrote:

Or, like WITNESS or MALLOC_PRODUCTION, on in HEAD and off in stable branches?

My thinking here is few of us are LLVM developers, and it is not clear this is a benefit to apply broadly. I am less certain on where MALLOC_PRODUCTION should fall, if the thought is it catches src errors than that is a favor for keeping it on in HEAD. WITNESS is directly relevant to HEAD development and the pkgbase now makes it easy to opt out.