loader: Rework kernel menu section
ClosedPublic
Actions

Authored by manu on Jan 7 2025, 9:40 AM.

Details

Reviewers

tsoome
imp

Group Reviewers

Loader

Commits

rGee233742a569: loader: Rework kernel menu section

Summary

With pkgbase we can have long kernel name, so create a new section
for the kernel name.
Do not show the "default" text, we already show the "1 of X" part at
the end of the line and the default kernel is always number 1 so it's a bit
redundant.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Test Plan

Before: https://people.freebsd.org/~manu/IMG_20250107_095722.jpg
After: https://people.freebsd.org/~manu/IMG_20250107_095848.jpg

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Jan 7 2025, 9:40 AM

Herald added subscribers: dab, imp. · View Herald TranscriptJan 7 2025, 9:40 AM

manu requested review of this revision.Jan 7 2025, 9:40 AM

Harbormaster completed remote builds in B61536: Diff 148862.Jan 7 2025, 9:40 AM

manu added a parent revision: D48353: loader: Fix orb position.Jan 7 2025, 9:40 AM

manu edited the test plan for this revision. (Show Details)Jan 7 2025, 9:41 AM

manu added a reviewer: Loader.

tsoome accepted this revision.Jan 7 2025, 10:11 AM

This revision is now accepted and ready to land.Jan 7 2025, 10:11 AM

I think this is sane...

stand/lua/menu.lua
350	thanks for preserving this.

Closed by commit rGee233742a569: loader: Rework kernel menu section (authored by manu). · Explain WhyJan 9 2025, 7:12 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rGee233742a569: loader: Rework kernel menu section.

Revision Contents
Changeset List

Path

Size

stand/

lua/

menu.lua

24 lines

Diff 148966

View Options

loader: Rework kernel menu sectionClosedPublicActions