sysctlinfo interface
AbandonedPublic
Actions

Authored by asiciliano on Sep 18 2019, 3:55 AM.

Details

Reviewers

emaste
markj
imp

Group Reviewers

manpages

Summary

sysctlinfo is a new interface to explore the sysctl MIB-Tree and to pass objects info to userland,
https://papers.freebsd.org/2020/bsdcan/siciliano-sysctlinfo/
https://gitlab.com/alfix/sysctlinfo

After a refactoring the kernel computation is ~100% more efficient than the undocumented interface to pass all info about an object to userland.

Currently it is used by:
sysutils/sysctlbyname-improved-kmod
devel/libsysctlmibinfo2
audio/mixertui
sysutils/nsysctl
deskutils/sysctlview
sysctl-mib-html (https://gitlab.com/alfix/sysctl-mib-html)

Test Plan

The interface is used by several ports,
Furthermore https://gitlab.com/alfix/sysctlinfo has

testing/ misc tests (name, CTL_MAXNAME levels, etc)
testing/regression/ compatibility with the 'undocumented interface'
testing/time/: efficiency
testing/lock/: trivial nodes to test lock/system panic
converted/: converted tools (sysctl, sysctlbyname,sysctlnametomib)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

asiciliano created this revision.Sep 18 2019, 3:55 AM

Herald added a reviewer: manpages. · View Herald TranscriptSep 18 2019, 3:55 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

asiciliano edited the summary of this revision. (Show Details)Sep 18 2019, 4:07 AM

asiciliano edited the test plan for this revision. (Show Details)

Only a minor comma missing in the man page. Otherwise, it's great.
Thank you!

share/man/man3/sysctlinfo.3
169	s/format respectively/format, respectively/

asiciliano added a comment.Sep 18 2019, 4:35 PM

This comment was removed by asiciliano.

share/man/man3/sysctlinfo.3
169	I' ll update, thank you

update the manual page to address revision feedback

OK from manpages. Someone else should look at the actual code to see if there are issues.

kai added a subscriber: kai.Sep 20 2019, 6:35 AM

lantw44_gmail.com added a subscriber: lantw44_gmail.com.Sep 26 2019, 5:58 AM

asiciliano edited the summary of this revision. (Show Details)Sep 28 2019, 5:02 AM

asiciliano edited the test plan for this revision. (Show Details)

Update sysctlinfo.h: CTL_SYSCTL is in sysctl.h
Improve lock (use a shared lock updating sysctl.h/kern_sysctl.c)
Move the implementation to kern_mib.c (sysctlinfo uses nothing from kern_sysctl.c)
Update man/man[3|4]/Makefile

tz mentioned this in rP514063: sysutils/sysctlinfo-kmod: update to 20191005.Oct 8 2019, 9:31 AM

asiciliano edited the summary of this revision. (Show Details)Nov 20 2019, 7:57 PM

asiciliano edited the test plan for this revision. (Show Details)

asiciliano edited the summary of this revision. (Show Details)Nov 21 2019, 8:49 PM

asiciliano added reviewers: emaste, markj.

asiciliano added a reviewer: imp.Jun 7 2020, 12:35 PM

asiciliano mentioned this in D27035: Add versioning support for kernel<>userland sysctl interface.Nov 1 2020, 2:43 AM

asiciliano edited the test plan for this revision. (Show Details)Nov 1 2020, 3:25 AM